Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed provided but shaded dependencies in modules by configuring a global shading rule #693

Merged
merged 1 commit into from
May 15, 2018
Merged

Fixed provided but shaded dependencies in modules by configuring a global shading rule #693

merged 1 commit into from
May 15, 2018

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented May 15, 2018

Fixes #656

Background:
Some modules were using shaded dependencies of core without doing the relocation.
This change will ensure that every module is using the same package as core to avoid it in future

@bsideup bsideup requested review from rnorth and kiview May 15, 2018 15:37
@bsideup bsideup added this to the next milestone May 15, 2018
rnorth
rnorth approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsideup bsideup merged commit a36451e into master May 15, 2018
@bsideup bsideup mentioned this pull request Jun 8, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth approved these changes

@kiview kiview Awaiting requested review from kiview

Assignees
No one assigned
Labels
area/shading blocker type/bug
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsideup @rnorth