Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Add the ability to specify an image's platform. #7312

Closed
shawjef3 opened this issue Jul 18, 2023 · 2 comments
Closed

[Enhancement]: Add the ability to specify an image's platform. #7312

shawjef3 opened this issue Jul 18, 2023 · 2 comments
Labels
type/enhancement

Comments

@shawjef3
Copy link
Contributor

Module

Core

Proposal

It's possible to specify the platform for a container by using GenericContainer#withCreateContainerCmdModifier.
However, it's not possible to do the same when creating an image, and so it's
not possible to both create and test an image for a platform.

Add ImageFromDockerfile#withBuildImageCmdModifier which will make this possible.
@shawjef3 shawjef3 mentioned this issue Jul 18, 2023
Merged
@eddumelendez
Copy link
Member

Hi @shawjef3, thanks for the proposal. However, for further reference, it would be ideal to discuss about this via GH Discussions and then we can decide if proceed or not with it and create an issue.

I'm closing this due to there is already an PR created.

@eddumelendez eddumelendez closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2023
@shawjef3
Copy link
Contributor Author

@eddumelendez #7315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shawjef3 @eddumelendez