Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying the rate limiter for AbstractWaitStrategy #837

Closed
chibenwa opened this issue Aug 17, 2018 · 4 comments
Closed

Allow specifying the rate limiter for AbstractWaitStrategy #837

chibenwa opened this issue Aug 17, 2018 · 4 comments
Labels
type/feature
Milestone
1.9.0-rc1

Comments

@chibenwa
Copy link
Contributor

The default rate limit for AbstractWaitStrategy is a constant rate of one try per second.

While this safe choice makes sense, some quick-to-start container would benefit from higher rates and thus making testcontainer faster.

My proposal is to add a withRateLimiter method to AbstractWaitStrategy allowing to override the default DOCKER_CLIENT_RATE_LIMITER.
@chibenwa
Copy link
Contributor Author

PR available here: #838

@rnorth rnorth added this to the 1.9.0 milestone Sep 10, 2018
@rnorth
Copy link
Member

rnorth commented Sep 10, 2018

We have this out in a Release Candidate build (1.9.0-rc1) for anyone who is keen to try it!

Release notes

@chibenwa
Copy link
Contributor Author

Cool, I will have a look!

Is there some planned release date for 1.9.0?

@bsideup bsideup modified the milestones: 1.9.0-rc1, next Sep 12, 2018
@bsideup bsideup closed this as completed Sep 24, 2018
@bsideup
Copy link
Member

bsideup commented Sep 24, 2018

Released as 1.9.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
1.9.0-rc1
Development

No branches or pull requests
3 participants
@rnorth @bsideup @chibenwa