fix: Add memcached container #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romulojales
force-pushed
the
add-memcached
branch
from
30a1f3e
to
c15abb3
Compare
|
@romulojales @pffijt Can you get this merged and released? |
romulojales
force-pushed
the
add-memcached
branch
from
c15abb3
to
2078179
Compare
Hello @damjankuznar , I just rebased the PR with the latest main version. Since I don't manage the project, I'm also waiting for the maintainers to review, and hopefully, approve my pr, so I could work with it without using my own fork. |
alexanderankin
added
community-feat
alexanderankin
force-pushed
the
add-memcached
branch
2 times, most recently
from
9f9e66a
to
9dadeb7
Compare
|
original commits are here - https://github.com/testcontainers/testcontainers-python/commits/romulojales/add-memcached |
alexanderankin
pushed a commit
that referenced
this pull request
May 14, 2024
🤖 I have created a release *beep* *boop* --- ## [4.4.1](testcontainers-v4.4.0...testcontainers-v4.4.1) (2024-05-14) ### Bug Fixes * Add memcached container ([#322](#322)) ([690b9b4](690b9b4)) * Add selenium video support [#6](#6) ([#364](#364)) ([3c8006c](3c8006c)) * **core:** add empty _configure to DockerContainer ([#556](#556)) ([08916c8](08916c8)) * **core:** remove version from compose tests ([#571](#571)) ([38946d4](38946d4)) * **keycloak:** add realm imports ([#565](#565)) ([f761b98](f761b98)) * **mysql:** Add seed support in MySQL ([#552](#552)) ([396079a](396079a)) * url quote passwords ([#549](#549)) ([6c5d227](6c5d227)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Memcached container.
You have implemented a new container and would like to contribute it? Great! Here are the necessary steps.
__init__.py) and corresponding tests.-e file:[feature name]torequirements.inand runmake requirements. This command will find any new requirements and generate lock files to ensure reproducible builds (see the pip-tools documentation for details). Then runpip install -r requirements/[your python version].txtto install the new requirements.README.rstand add it to the table of contents (toctreedirective) in the top-levelREADME.rst.[feature name]to the list of components in the GitHub Action workflow in.github/workflows/main.ymlto run tests, build, and publish your package when pushed to themasterbranch.master(or mergemasterinto your development branch).