fix(vault): add support for HashiCorp Vault container #366
Conversation
|
@tillahoffmann Am I correct in assuming I need to wait for workflow approval before I can continue to update the dependencies for this PR? |
alexanderankin
added
the
community-feat
alexanderankin
changed the title
|
Hi @f4z3r! Thank you for your contribution, Hashicorp's Vault is something we would like to see supported. We are sorry for the extended delay in feedback and merged PRs, but are now on back on track with active maintainers. Could you please rebase or merge in the latest changes from |
|
@santi sure thing. I will get to it over the next couple of days 👍🏽 |
|
@santi alright I updated the PR to be according to the new repo structure. I am not super familiar with Poetry, but it seemed I needed to update the entire lock file to install the required packages I added to run the tests. As far as I could check, it seems to run fine, |
|
Good work so far, @f4z3r! With this speed we are ready to merge the module today 😄 |
|
Tests are failing because the specified |
Well thanks for the quick reviews and your help! 😄 |
There was a problem hiding this comment.
Great work! 💯 Thank you for your contribution.
Looks like Github Actions hit a bit of a bump right when everything was done, so only half of the checks have passed, and I'm getting 500 Errors randomly. Once https://github.com/testcontainers/testcontainers-python/actions/runs/8567034738, https://github.com/testcontainers/testcontainers-python/actions/runs/8567034549 and https://github.com/testcontainers/testcontainers-python/actions/runs/8567034548 have run, I'll merge 👍
Yup, seems GitHub is experiencing issues: https://www.githubstatus.com/ |
|
@f4z3r Seems like the trouble is over, but the queued tasks are not running. Could you re-trigger a new set of checks by pushing a commit with |
🤖 I have created a release *beep* *boop* --- ## [4.3.2](testcontainers-v4.3.1...testcontainers-v4.3.2) (2024-04-08) ### Bug Fixes * **core:** Improve typing for common container usage scenarios ([#523](#523)) ([d5b8553](d5b8553)) * **core:** make config editable to avoid monkeypatching.1 ([#532](#532)) ([3be6da3](3be6da3)) * **vault:** add support for HashiCorp Vault container ([#366](#366)) ([1326278](1326278)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…#366) Add support for a Vault container.
🤖 I have created a release *beep* *boop* --- ## [4.3.2](testcontainers/testcontainers-python@testcontainers-v4.3.1...testcontainers-v4.3.2) (2024-04-08) ### Bug Fixes * **core:** Improve typing for common container usage scenarios ([testcontainers#523](testcontainers#523)) ([d5b8553](testcontainers@d5b8553)) * **core:** make config editable to avoid monkeypatching.1 ([testcontainers#532](testcontainers#532)) ([3be6da3](testcontainers@3be6da3)) * **vault:** add support for HashiCorp Vault container ([testcontainers#366](testcontainers#366)) ([1326278](testcontainers@1326278)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Add support for a Vault container.