Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modules): SFTP Server Container #629

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

oliverlambson
Copy link
Contributor

@oliverlambson oliverlambson commented Jun 30, 2024

New Container

Fixes #628

PR Checklist

  • Your PR title follows the Conventional Commits syntax
    as we make use of this for detecting Semantic Versioning changes.
  • Your PR allows maintainers to edit your branch, this will speed up resolving minor issues!
  • The new container is implemented under modules/*
    • Your module follows PEP 420 with implicit namespace packages
      (if unsure, look at other existing community modules)
    • Your package namespacing follows testcontainers.<modulename>.*
      and you DO NOT have an __init__.py above your module's level.
    • Your module has it's own tests under modules/*/tests
    • Your module has a README.rst and hooks in the .. auto-class and .. title of your container
    • Implement the new feature (typically in __init__.py) and corresponding tests.
  • Your module is added in pyproject.toml
    • it is declared under tool.poetry.packages - see other community modules
    • it is declared under tool.poetry.extras with the same name as your module name,
      we still prefer adding NO EXTRA DEPENDENCIES, meaning mymodule = [] is the preferred addition
      (see the notes at the bottom)
  • The INDEX.rst at the project root includes your module under the .. toctree directive
  • Your branch is up to date (or we'll use GH's "update branch" function through the UI)

Preferred implementation

  • The current consensus among maintainers is to try to avoid enforcing the client library
    for the given tools you are triyng to implement.
  • This means we want you to avoid adding specific libraries as dependencies to testcontainers.
  • Therefore, you should implement the configuration and the waiting with as little extra as possible
  • You may still find it useful to add your preferred client library as a dev dependency

@oliverlambson oliverlambson marked this pull request as draft June 30, 2024 21:49
@oliverlambson oliverlambson marked this pull request as ready for review June 30, 2024 21:53
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@16f6ca4). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #629   +/-   ##
=======================================
  Coverage        ?   76.26%           
=======================================
  Files           ?       11           
  Lines           ?      573           
  Branches        ?       83           
=======================================
  Hits            ?      437           
  Misses          ?      110           
  Partials        ?       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexanderankin alexanderankin added the community-feat feature but its a community module so we wont bump tc core for it label Jun 30, 2024
@alexanderankin alexanderankin merged commit 2e7dbf1 into testcontainers:main Jun 30, 2024
15 checks passed
@oliverlambson oliverlambson deleted the feat/sftp-container branch July 1, 2024 06:56
alexanderankin pushed a commit that referenced this pull request Jul 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.7.1](testcontainers-v4.7.0...testcontainers-v4.7.1)
(2024-07-02)


### Bug Fixes

* **core:** bad rebase from
[#579](#579)
([#635](#635))
([4766e48](4766e48))
* **modules:** Mailpit Container
([#625](#625))
([0b866ff](0b866ff))
* **modules:** SFTP Server Container
([#629](#629))
([2e7dbf1](2e7dbf1))
* **network:** Now able to use Network without context, and has labels
to be automatically cleaned up
([#627](#627))
([#630](#630))
([e93bc29](e93bc29))
* **postgres:** get_connection_url(driver=None) should return
postgres://...
([#588](#588))
([01d6c18](01d6c18)),
closes
[#587](#587)
* update test module import
([#623](#623))
([16f6ca4](16f6ca4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-feat feature but its a community module so we wont bump tc core for it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Container: SFTP server
2 participants