Editor support for Atom

[searls]

Talk to someone from AtomLinter and fork or extend linter-rubocop

[tmikeschu]

👋 I'd like to work on this issue!

[searls]

TIL I can't assign people without commit bit.

[searls]

Consider yourself assigned, Mike

[tmikeschu]

Haven't made any progress on this yet (ended up in a position with less free time 😢 ). Still hoping to contribute, but if someone sees this and wants to take a stab let me know.

[martinliptak]

Actually, standardrb almost works with linter-rubocop out of the box. The only problem is the message that standardrb adds to rubocop output at the end.

Notice: Disagree with these rules? While StandardRB is pre-1.0.0, feel free to submit suggestions to:
  https://github.com/testdouble/standard/issues/new

@searls Could this be written to stderr rather than stdin? That could fix the issue because linter-rubocop parses only stdout.

https://github.com/AtomLinter/linter-rubocop/blob/master/src/index.js#L39

I've made a script that filters out the message and set linter-rubocop to use it as rubocop executable.

#!/bin/bash

bin/standardrb $@ | grep -v "Notice: " | grep -v "https://github.com/testdouble/standard/issues/new"

This is the result:

Seems to be working.

[martinliptak]

bin/standardrb-atom is the script that removes "Notice: ..." from the output. Writing the notice to stderr should make standardrb compatible with rubocop-linter and possibly other editors that work with rubocop. The user would just set rubocop-linter executable to bin/standardrb.

Will keep testing this to see if everything works.

[martinliptak]

Alternatively, standardrb could detect --format json and hide notice.

[rosston]

Hm, there was an issue for fixing this: #53. I was under the impression that --format json disabled the "Notice: ..." message now due to #55 (landed in v0.0.23).

@martinliptak Does --format json still show that message for you?

[searls]

Yes, make sure the gem is up-to-date! --format json no longer shows the notice. It was added to the standard built-in formatter quite a while ago

[martinliptak]

Thank you @rosston and @searls

After updating the gem, standardrb works with linter-rubocop. The only thing I had to do was setting ./bin/standardrb as command in linter-rubocop settings.

Is this something you want to add to the How do I run standard in my editor? README section?

[searls]

Yes, please send a PR!

[matt17r]

Can this be closed now? Instructions are clear and linter issues are flagged nicely.

[searls]

Sure!