Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructor replacements will fail instanceof checks #107

Closed
searls opened this issue Jun 3, 2016 · 1 comment
Closed

Constructor replacements will fail instanceof checks #107

searls opened this issue Jun 3, 2016 · 1 comment

Comments

@searls
Copy link
Member

searls commented Jun 3, 2016

See #103 for backstory, but the tl;dr is that a constructor replaced with td.replace module replacement will fail an instanceof test when compared to the actual type.
This was referenced Jun 3, 2016
Closed
Closed
@searls searls mentioned this issue Dec 14, 2016
Closed
@searls
Copy link
Member Author

searls commented Dec 14, 2016

This is now an acceptance criteria of #166, closing to track it there.

@searls searls closed this as completed Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@searls