Wrong test double name for proxies

[mgryszko]

Cloned the project - current commit is 4c4c1b7. Then npm run test. Got 2 failures:

  1) td.object creating a proxy object (ES2015; only supported in FF + Edge atm) then this.testDouble.toString() === '[test double object for "Thing"]':
     Error: return value is false
     Expected '[test double object]' to strictly equal '[test double object for "Thing"]'
     Comparison: this.testDouble.toString() === '[test double object for "Thing"]'

  2) td.object creating a proxy object (ES2015; only supported in FF + Edge atm) then this.testDouble.foo.toString() === '[test double for "Thing#foo"]':
     Error: return value is false
     Expected '[test double for "#foo"]' to strictly equal '[test double for "Thing#foo"]'
     Comparison: this.testDouble.foo.toString() === '[test double for "Thing#foo"]'

I'm dropping this error report while I'm trying to investigate why this is happening.

[searls]

Did Node 6 add support for ES Proxy objects? If so it sounds like the error is actually just it working.

On Jun 19, 2016, at 18:30, Marcin Gryszko notifications@github.com wrote:

Cloned the project - current commit is 4c4c1b7. Then npm run test. Got 2 failures:

1. td.object creating a proxy object (ES2015; only supported in FF + Edge atm) then this.testDouble.toString() === '[test double object for "Thing"]':
   Error: return value is false
   Expected '[test double object]' to strictly equal '[test double object for "Thing"]'
   Comparison: this.testDouble.toString() === '[test double object for "Thing"]'

2. td.object creating a proxy object (ES2015; only supported in FF + Edge atm) then this.testDouble.foo.toString() === '[test double for "Thing#foo"]':
   Error: return value is false
   Expected '[test double for "#foo"]' to strictly equal '[test double for "Thing#foo"]'
   Comparison: this.testDouble.foo.toString() === '[test double for "Thing#foo"]'
   I'm dropping this error report while I'm trying to investigate why this is happening.

―
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[mgryszko]

Proxy native support was added in Node 6.0.0.

According to Kangax, Proxy is fully supported in:

• FF >= 48
• Chrome >= 51
• Edge >= 12

Next version of Safari should get the support too.

[mgryszko]

PR coming soon