Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify times() #5

Closed
searls opened this issue Sep 7, 2015 · 4 comments · Fixed by #40
Closed

Add verify times() #5

searls opened this issue Sep 7, 2015 · 4 comments · Fixed by #40

Comments

@searls
Copy link
Member

searls commented Sep 7, 2015

Once #4 is added, then consider adding:

verify(testDouble("lol"), times: 18)

To ensure this verification was satisfied 18 times.
@mweitzel
Copy link

mweitzel commented Oct 7, 2015

+1, especially for asserting 0 times.

@searls
Copy link
Member Author

searls commented Oct 24, 2015

I'd like to support as many options as possible for both when and verify. Keeping their APIs symmetrical is important to me, because it's so hard for end-users to keep the two functions straight.

So, for verify, it should verify that the callCount is what was said. For when, I suppose times should stop matching the stubbing at all if the call count exceeds times

@searls searls mentioned this issue Oct 24, 2015
Merged
4 tasks
@searls
Copy link
Member Author

searls commented Oct 25, 2015

Hey @mweitzel this landed in 0.5.0 just now

@mweitzel
Copy link

Sweet, thanks. I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a times option testdouble/testdouble.js
2 participants
@searls @mweitzel