Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws in node 0.10 #94

Closed
terinjokes opened this issue Apr 3, 2016 · 2 comments
Closed

Throws in node 0.10 #94

terinjokes opened this issue Apr 3, 2016 · 2 comments

Comments

@terinjokes
Copy link

In src/store/index.js you import events as EventEmitter. This change happened after node 0.10 and 0.12. As these versions are still LTS versions in mantaince mode, I need to continue to support testing them in my test suites.

@searls
Copy link
Member

searls commented Apr 3, 2016

Good catch. Could you send a quick PR to fix it?

On Apr 2, 2016, at 21:37, Terin Stock notifications@github.com wrote:

In src/store/index.js you import events as EventEmitter. This change happened after node 0.10 and 0.12. As these versions are still LTS versions in mantaince mode, I need to continue to support testing them in my test suites.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

@searls searls closed this as completed in 3b53d5c Apr 3, 2016
@searls
Copy link
Member

searls commented Apr 3, 2016

This is fixed in 1.3.1. Thanks!

On Apr 2, 2016, at 21:37, Terin Stock notifications@github.com wrote:

In src/store/index.js you import events as EventEmitter. This change happened after node 0.10 and 0.12. As these versions are still LTS versions in mantaince mode, I need to continue to support testing them in my test suites.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants