Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project update #8

Closed
wants to merge 5 commits into from
Closed

Project update #8

wants to merge 5 commits into from

Conversation

jonra1993
Copy link

Thanks for this fastapi setup. In this Pull request, I have added some suggestions on issues

  1. nullable=False on id
  2. settings file
  3. db file upgrade
  4. readme add how to make migrations with alembic

@jonra1993 jonra1993 closed this Mar 7, 2022
@mjhea0
Copy link
Contributor

mjhea0 commented Mar 8, 2022

Why did you close this, @jonra1993?

@jonra1993
Copy link
Author

jonra1993 commented Mar 12, 2022

Hello @mjhea0 I thought this project was not maintained due to I did not have a response about PR so I decided to edit the folder structure which caused a full refactoring of your original setup as you can see here 86e00a7 I can reopen PR removing the Upgrade project structure commit if you are going to continue maintaining this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants