Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error while loading in new .ics File! #2

Closed
phibr0 opened this issue Oct 24, 2020 · 2 comments
Closed

Error while loading in new .ics File! #2

phibr0 opened this issue Oct 24, 2020 · 2 comments
Assignees
@TesteurManiak
Labels
enhancement New feature or request

Comments

@phibr0
Copy link

phibr0 commented Oct 24, 2020

Many auto generated .ics Files end with an empty line under the END:VCALENDAR, but this package throws an error saying the file doesnt end with an END:VCALENDAR Statement. If i find some time in the near future i will propably open a Pull Request fixing this issue.
@TesteurManiak
Copy link
Owner

TesteurManiak commented Oct 24, 2020 •
edited

You are right, I'm going to fix this but if you open a PR before I'll be glad to merge it :)

@TesteurManiak
Copy link
Owner

Just've made a fix published in version 0.1.1 of the package. If empty lines are allowed in the parsing (which is enabled by default) it won't throw an error anymore if there is a newline at the end of the file.

@TesteurManiak TesteurManiak added the invalid This doesn't seem right label Oct 24, 2020
@TesteurManiak TesteurManiak added enhancement New feature or request and removed invalid This doesn't seem right labels Feb 4, 2021
@TesteurManiak TesteurManiak self-assigned this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TesteurManiak TesteurManiak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TesteurManiak @phibr0