Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) Rename window methods to targetWindow(), listWindows(), and window(). #238

Merged
merged 1 commit into from Dec 5, 2015

Conversation

hastebrot
Copy link
Member

Changes:

  • Add all missing window finder methods to FxRobot.
  • Rename pos() to targetPos().
  • Rename target() to targetWindow() to emphasize that it is a window-related method.
  • Rename listOrderedWindows() to listTargetWindows() to emphasize the relationship to targetWindow().
  • Add window() variants with parameter Predicate<Window>, Stage, and Node.

Interface:

interface WindowFinder {
    Window targetWindow();
    void targetWindow(Window window);
    void targetWindow(Predicate<Window> predicate);

    List<Window> listWindows();
    List<Window> listTargetWindows();
    Window window(Predicate<Window> predicate);

    // Convenience methods:
    void targetWindow(int windowIndex);
    void targetWindow(String stageTitleRegex);
    void targetWindow(Pattern stageTitlePattern);
    void targetWindow(Scene scene);
    void targetWindow(Node node);

    Window window(int windowIndex);
    Window window(String stageTitleRegex);
    Window window(Pattern stageTitlePattern);
    Window window(Scene scene);
    Window window(Node node);
}

hastebrot added a commit that referenced this pull request Dec 5, 2015
(refactor) Rename window methods to `targetWindow()`, `listWindows()`, and `window()`.
@hastebrot hastebrot merged commit 9cfa735 into TestFX:master Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant