Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types in DefinitelyTyped are missing v5 find* API #84

Closed
jrnail23 opened this issue Sep 13, 2019 · 2 comments
Closed

Types in DefinitelyTyped are missing v5 find* API #84

jrnail23 opened this issue Sep 13, 2019 · 2 comments

Comments

@jrnail23
Copy link

  • cypress-testing-library version:
  • node version:
  • npm (or yarn) version:

Relevant code or config

What you did:

What happened:

Reproduction repository:

Problem description:

Suggested solution:

@bastibuck
Copy link
Contributor

Were all getBy* methods directly replaced with findBy*? should be pretty straight forward in this case to update the type definitions at https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__cypress

@bastibuck
Copy link
Contributor

I've created a PR over at DefinitelyTyped/DefinitelyTyped#38368
Need to wait for the merge to happen and then update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants