Have queryAllBySelectText query using reactive properties #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
馃帀 This PR is included in version 3.10.1 馃帀 The release is available on:
Your semantic-release bot 馃摝馃殌 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Replace the existing select query mechanism which uses
HTMLSelectElement .selectedOptionswith a query that searches for theselectedattribute of anHTMLOptionElement.Why:
Closes #115.
Since
selectedOptionsis not a reactive property, JSDOM was not updating to match the selected option in a select Element. Theselectedattribute is reactive.How:
Instead of iterating through
selectedOptionsof an HTMLSelectElement, we iterate through all HTMLSelectOptions and isolate the ones that are selected.I've gone ahead and tested this locally to make sure that it would be reactive! 馃憤
Checklist: