[fix] Allow any element as valid for aria-labelledby #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@all-contributors please add @paularmstrong for code and tests |
|
We had trouble processing your request. Please try again later. |
|
@all-contributors please add @paularmstrong for code and tests |
|
I've put up a pull request to add @paularmstrong! 🎉 |
|
I've put up a pull request to add @paularmstrong! 🎉 |
|
🎉 This PR is included in version 5.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
See #271 for more context.
Why:
It is valid to allow any element to be the label when using
aria-labelledby, not just<label>elements. The current implementation in dom-testing-library restricts tolabelelements.How:
Removed a filter that restricted to
labelelements.Checklist:
docs site