Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update deprecation warning for waitForElement #535

Merged

Conversation

kwboyd
Copy link
Contributor

@kwboyd kwboyd commented Apr 24, 2020

What:

Same issue as #478 but in the waitForElement deprecation warning. The warning when you use waitForElement currently says to use either find* or wait instead, but wait is deprecated as well.

Why:

Up-to-date deprecation warnings

How:

Updated warning to say waitFor instead of wait

Checklist:

  • Documentation added to the
    docs site N/A
  • I've prepared a PR for types targeting
    DefinitelyTyped N/A
  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ba9b903:

Sandbox Source
objective-https-ge726 Configuration

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #535 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #535   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          429       429           
  Branches       103       103           
=========================================
  Hits           429       429           
Impacted Files Coverage Δ
src/wait-for-element.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e66f3...ba9b903. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 6f0085d into testing-library:master Apr 24, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @kwboyd for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @kwboyd! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants