Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump pretty-format #751

Merged
merged 2 commits into from
Aug 22, 2020
Merged

fix: bump pretty-format #751

merged 2 commits into from
Aug 22, 2020

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Aug 22, 2020

What:

Bumping pretty-format to latest major

Why:

Keeping up is always a good thing. And also, v26 supports custom elements (testing-library/react-testing-library#679)

How:

Updated in GH webapp

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 98513ad:

Sandbox Source
kentcdodds/react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #751 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #751   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          657       657           
  Branches       173       173           
=========================================
  Hits           657       657           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bcf60e...98513ad. Read the comment docs.

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had to revert the bump the last time due #563. Does pretty format still require a specific node 10 version?

@SimenB
Copy link
Contributor Author

SimenB commented Aug 22, 2020

Aha! Jest 26 needs minimum that version due to bugs in the vm module fixed in that release. However, pretty-format doesn't care about that, we just did the same engine across all modules in the monorepo. We recently lowered the minimum for jest-worker, can do the same for pretty-format

@eps1lon
Copy link
Member

eps1lon commented Aug 22, 2020

@SimenB Sounds great. Once the fix in pretty-format is released we can update the version range here.

@SimenB
Copy link
Contributor Author

SimenB commented Aug 22, 2020

@eps1lon done

@eps1lon eps1lon added the bug Something isn't working label Aug 22, 2020
@eps1lon eps1lon merged commit 9cbc428 into testing-library:master Aug 22, 2020
@eps1lon
Copy link
Member

eps1lon commented Aug 22, 2020

@SimenB Thanks!

@SimenB SimenB deleted the bump-pretty-format branch August 22, 2020 18:14
@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.22.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants