fix: Pass container from findBy through to waitFor

[nathanforce]

What:

Pass container from findBy into the waitFor call to support using findBy in non-global DOM environments.

Why:

The library should be agnostic of the runtime environment/globals when passing in a container.

How:

It looks like there are sensible defaults for container throughout the call stack, so I've just ferried the argument through.

Checklist:

• Documentation added to the
  docs site n/a
• Tests
• Typescript definitions updated n/a
• Ready to be merged
  

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 50c6353:

Sandbox	Source
react-testing-library-examples	Configuration

[nathanforce]

This change was needed to keep these warnings intact. Without it, getWindowFromNode(container) throws and the error messages do not match the expected error. I thought it best to keep the warnings/behavior the same rather than update the test snapshots to match the new error message.

https://github.com/testing-library/dom-testing-library/blob/master/src/__tests__/base-queries-warn-on-invalid-container.js#L95-L127

[nathanforce]

Worth noting that I had to commit with --no-verify for this as it looks like #848 may have introduced a type error?

[typecheck] types/__tests__/type-tests.ts(30,22): error TS2345: Argument of type 'number' is not assignable to parameter of type 'Matcher'.

[marcosvega91]

Hi @nathanforce could you please rebase this branch with master?

[codecov]

Codecov Report

Merging #868 (50c6353) into master (71b4f46) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #868   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          946       951    +5     
  Branches       291       291           
=========================================
+ Hits           946       951    +5     

Impacted Files	Coverage Δ
src/query-helpers.js	100.00% <100.00%> (ø)
src/wait-for.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b4f46...50c6353. Read the comment docs.

[eps1lon]

@all-contributors add @nathanforce for code

[eps1lon]

@nathanforce Thanks!

[allcontributors]

@eps1lon

I've put up a pull request to add @nathanforce! 🎉

[github-actions]

🎉 This PR is included in version 7.29.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀