Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bump dom-accessibility-api #965

Merged
merged 1 commit into from
May 31, 2021
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 31, 2021

What:

Closes #940

Why:

Following screen-reader implementations.

How:

eps1lon/dom-accessibility-api#629

Checklist:

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f6d59aa:

Sandbox Source
react-testing-library-examples Configuration
react-testing-library demo Issue #940

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #965 (f6d59aa) into main (c273ed5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #965   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          966       966           
  Branches       293       298    +5     
=========================================
  Hits           966       966           
Flag Coverage Δ
node-10.14.2 100.00% <ø> (ø)
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-15 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c273ed5...f6d59aa. Read the comment docs.

@eps1lon eps1lon merged commit 86fb094 into testing-library:main May 31, 2021
@eps1lon eps1lon deleted the fix/optgroup branch May 31, 2021 11:38
@github-actions
Copy link

github-actions bot commented Jun 1, 2021

🎉 This PR is included in version 7.31.1-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

🎉 This PR is included in version 7.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to select an optgroup with getByRole
1 participant