Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drop support for node 10 #976

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 12, 2021

BREAKING CHANGE: node 10 is no longer supported. It reached its end-of-life on 30.04.2021.

What:

Closes #975
Closes #957

Why:

Reduces maintenance burden

How:

Change engines field to require node>=12

Checklist:

  • [ ] Documentation added to the
    docs site
    Will do once we release the alpha
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

BREAKING CHANGE: node 10 is no longer supported. It reached its end-of-life on 30.04.2021.
@eps1lon eps1lon added the BREAKING CHANGE This change will require a major version bump label Jun 12, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4487918:

Sandbox Source
react-testing-library-examples Configuration

@eps1lon eps1lon changed the title fix: Only use a single clock (#966) feat: Drop support for node 10 Jun 12, 2021
@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #976 (4487918) into alpha (9410e11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #976   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          914       914           
  Branches       286       286           
=========================================
  Hits           914       914           
Flag Coverage Δ
node-10.14.2 ?
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-15 ?
node-16 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9410e11...4487918. Read the comment docs.

@eps1lon eps1lon marked this pull request as ready for review June 12, 2021 09:36
@eps1lon eps1lon linked an issue Jun 12, 2021 that may be closed by this pull request
@eps1lon eps1lon merged commit fa3b91c into testing-library:alpha Jun 12, 2021
@eps1lon eps1lon deleted the feat/drop-node-10 branch June 12, 2021 09:39
@github-actions
Copy link

🎉 This PR is included in version 8.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump released on @alpha
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Node 10 support
1 participant