Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support resolves/rejects matchers for asynchronous queries #51

Closed
thomaslombart opened this issue Dec 10, 2019 · 2 comments · Fixed by #64
Closed

Support resolves/rejects matchers for asynchronous queries #51

thomaslombart opened this issue Dec 10, 2019 · 2 comments · Fixed by #64
Labels
enhancement New feature or request help wanted Extra attention is needed released

Comments

@thomaslombart
Copy link
Collaborator

As stated in #48, we are not handling the case where a user wraps a query in an expect statement and then uses the resolves or rejects matchers. For example, the following statement will trigger an error even if it's a valid case:

expect(findByText("foo")).resolves.toBe("bar")
@thomaslombart thomaslombart added the enhancement New feature or request label Dec 10, 2019
@thomaslombart thomaslombart added the help wanted Extra attention is needed label Jan 14, 2020
@thomaslombart
Copy link
Collaborator Author

I'll write a fix next week for that issue.

@thomaslombart thomaslombart mentioned this issue Jan 20, 2020
Merged
@Belco90
Copy link
Member

Belco90 commented Jan 22, 2020

🎉 This issue has been resolved in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
2 participants
@Belco90 @thomaslombart