fix(await-fire-event): reference correct method names in reported messages

[IvanAprea]

Checks

• I have read the contributing guidelines.
• If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
• If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

Issue link: #590

• I changed the awaitFireEvent prop from "methodName" to "name"
• I changed the fireEventWrapper prop from "wrapperName" to "name"
• I fixed the fireEventWrapper test in order to use the wrapper function name, and no the fire event function name.

I am showing the errors with gitLens

Context

[IvanAprea]

@Belco90 👀

[Belco90]

Thanks for taking care of this!

I think we need to do the change in the other message. Additionally, can you update the tests for this rule so they check that the correponding name property is passed to the messages?

[IvanAprea]

@Belco90 I did another commit with the changes for the messageId: fireEventWrapper. I changed the var to name and fixed the test in order to use the wrapper function name. I saw the rest of tests and i think that they are well. The tests didnt fail before because the var name in the messages was wrong. Please let me know if you have any doubt or if you need that i test anymore

[Belco90]

Looks great! Thanks for your contribution 👌

It's annoying that tests weren't failing for an unexpected data property provided, we will have to look into how to prevent this in the future.

[github-actions]

🎉 This PR is included in version 5.5.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Belco90]

@all-contributors please add @IvanAprea for code and tests

[allcontributors]

@Belco90

I've put up a pull request to add @IvanAprea! 🎉