Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(no-node-access): add allowContainerFirstChild option #611

Merged
merged 1 commit into from
Jul 30, 2022
Merged

feat(no-node-access): add allowContainerFirstChild option #611

merged 1 commit into from
Jul 30, 2022

Conversation

Semigradsky
Copy link
Contributor

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • Add allowContainerFirstChild option to no-node-access rule

Context

Fixes #593

Belco90
Belco90 requested changes Jul 23, 2022
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @Semigradsky!

LGTM, just a small improvement in the rule doc and should be ready to go.

docs/rules/no-node-access.md Outdated Show resolved Hide resolved
@Semigradsky Semigradsky force-pushed the pr/no-node-access_add_allowContainerFirstChild branch from ef98c9e to 0f39b33 Compare July 23, 2022 21:46
@Semigradsky Semigradsky requested a review from Belco90 July 23, 2022 21:47
@Belco90 Belco90 merged commit d16d284 into testing-library:main Jul 30, 2022
@Belco90
Copy link
Member

Belco90 commented Jul 30, 2022

@all-contributors please add @Semigradsky for code, test and docs

@allcontributors allcontributors bot mentioned this pull request Jul 30, 2022
Merged
@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @Semigradsky! 🎉

@github-actions
Copy link

🎉 This PR is included in version 5.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow exceptions for "no-node-access"
2 participants
@Semigradsky @Belco90