Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export type TestingLibraryMatchers from "./matchers" #576

Merged

Conversation

jakeboone02
Copy link
Contributor

What:

This PR adds an export of the type TestingLibraryMatchers to the "./matchers" export.

This is a little weird because the TestingLibraryMatchers type is not strictly relevant to the "./matchers" export--part of the reason #566 was submitted in the first place. TestingLibraryMatchers really only applies to the default "." export, but since the default export isn't a module (because it doesn't export anything), "./matchers" is probably the right place.

Why:

#566 introduced an unintended breaking change.

Checklist:

  • Documentation - N/A
  • Tests - N/A
  • Updated Type Definitions
  • Ready to be merged

Copy link

@AxelEriksson0 AxelEriksson0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@gnapse gnapse merged commit dd1c4dd into testing-library:main Feb 1, 2024
5 checks passed
Copy link

github-actions bot commented Feb 1, 2024

🎉 This PR is included in version 6.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gnapse
Copy link
Member

gnapse commented Feb 1, 2024

@all-contributors please add @jakeboone02 for code, test

Copy link
Contributor

@gnapse

I've put up a pull request to add @jakeboone02! 🎉

@jakeboone02 jakeboone02 deleted the pr/export-main-matcher-type branch February 1, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants