-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling toBeDisabled matcher for TextInput elements #15
Conversation
Hi there, thanks for the PR! The issue in the new tests is that you're looking for the Thanks again! We'll get this merged once the PR is updated 👍 |
Oh, nice one, thanks! I've changed the accessibilityStates for editable that feels less imperative? Let me know what you think |
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 8 8
Lines 90 90
Branches 23 23
=====================================
Hits 90 90
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this works for me. Thanks!
@allcontributors please add @acatalina for code |
I've put up a pull request to add @acatalina! 🎉 |
* add textInput for disabled support * add textInputs tests * fix tests
…) (#17) * add textInput for disabled support * add textInputs tests * fix tests
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
What:
Enabling toBeDisabled matcher for TextInput elements
Why:
They were ignored before
How:
Just added TextInput as a valid disabled element
Checklist:
docs
Hi! Thanks for this library first of all :)
So I have added some tests but I am having a weird problem with them. It looks like the element is passing as null for some reason. I've tried to update react native and testing library but the issue carries on happening. Wondering if you could help with this little bit and have the PR ready?
Thanks again