Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preact and preact-testing-library should be defined as devDependencies #8

Closed
aduth opened this issue Sep 13, 2020 · 0 comments · Fixed by #9
Closed

Preact and preact-testing-library should be defined as devDependencies #8

aduth opened this issue Sep 13, 2020 · 0 comments · Fixed by #9

Comments

@aduth
Copy link
Contributor

aduth commented Sep 13, 2020

preact and @testing-library/preact are defined as peer dependencies:

"peerDependencies": {
"@testing-library/preact": "^1.0.2",
"preact": "^10.4.1"
},

This makes sense for external consumers, but causes issues in local development, since TypeScript type checking will be unable to find types for the preact and @testing-library/preact packages, unless they are available in global caches.

To ensure that type definitions for preact and @testing-library/preact are available, they should be additionally be installed as devDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant