-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post-upgrade, unexpected assertion failures on error-handling function calls (includes repro) #1127
Comments
Same for me. When I upgraded TL/R version 13 and run |
Same for me. Why do we need to plaster each test with wait For ? ... Please resolve this issue asap. |
Do we still have to plaster each of the test case with waitFor ? |
My issue was resolved. We don't need to plaster each test with waitFor. It was failing because userevent Library was also updated, with its current latest version it has now made all user events asynchronous. So just needed to add await to all userevent calls and it resolved all test cases. |
@shank2512 |
@testing-library/react
version: 13.4.0Relevant code or config:
What you did:
Upgraded existing application to react 18+ and RTL 13+.
What happened:
A number of tests starting failing assertions after upgrading.
In this case, the component is rendered with a simulated
fetch
failure. The component renders a child component that is responsible for error presentation and minor logging (in an effect hook). The test assertion on the logging function call fails unless it is awaited.Reproduction:
I was able to reproduce the issue with a simple CRA repo, here: https://github.com/trv-wcaneira/fetch-err-waitfor-mcve
Problem description:
Pre-upgrade, it was sufficient to
await
the error message text rendered by the child component. Now it seems additional waiting is needed, and before I plasterwaitFor
s all over our tests 😄, I'd just like to understand why.Suggested solution:
I could obviously change all the tests to
waitFor
the logging function call, but would like to understand the change in behavior.The text was updated successfully, but these errors were encountered: