Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update all deps #842

Merged
merged 1 commit into from
Dec 4, 2020
Merged

chore: update all deps #842

merged 1 commit into from
Dec 4, 2020

Conversation

kentcdodds
Copy link
Member

What: Update all deps

Why: Just to get things up-to-date.

How: npx ncu --dep prod,dev --upgrade && npm run lint -- --fix && npm run validate

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

Any maintainer is welcome to merge this 👍

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4839344:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #842 (4839344) into master (03bea9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #842   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          140       140           
  Branches        28        28           
=========================================
  Hits           140       140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03bea9f...4839344. Read the comment docs.

Comment on lines -2 to +3
import {render, fireEvent, screen, waitFor} from '@testing-library/react'
import * as pure from '@testing-library/react/pure'
import {render, fireEvent, screen, waitFor} from '.'
import * as pure from './pure'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get the paths config set to make this work like it was before. I'm personally not that bothered by this, but if someone cares, feel free to update it :)

@kentcdodds
Copy link
Member Author

This is ready to go. Anyone can feel free to click the green button if you're happy with the changes :)

Copy link
Member

@marcosvega91 marcosvega91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me is good, I'll merge thanksss 😄

@marcosvega91 marcosvega91 merged commit 64a8b9c into master Dec 4, 2020
@nickmccurdy nickmccurdy deleted the pr/update-deps branch December 4, 2020 21:01
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

🎉 This PR is included in version 11.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants