Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search shortcut icons detect OS after page load, can display wrong #661

Closed
maraisr opened this issue Nov 4, 2020 · 7 comments
Closed

Search shortcut icons detect OS after page load, can display wrong #661

maraisr opened this issue Nov 4, 2020 · 7 comments

Comments

@maraisr
Copy link

maraisr commented Nov 4, 2020

Describe the bug
There seems to be a flicker from what I assume is the mac button, to a control?

To Reproduce
Steps to reproduce the behavior:

  1. Go to website
  2. Refresh site
  3. Whilst refreshing look at search box

Expected behavior
There shouldnt be a flicker.

Screenshots
ezgif com-video-to-gif

please take notice of the search box

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox
  • Version: 83.0b7
@MatanBobi
Copy link
Member

MatanBobi commented Nov 4, 2020

Hi @maraisr, thanks for opening this issue!
This doesn't reproduce on Mac neither with Firefox (version 81.0.2) nor with Chrome.
At first glance, this looks like a bug within Docusaurus, can you please try to see if this reproduces for you also on docusaurus main site?

@maraisr
Copy link
Author

maraisr commented Nov 4, 2020

Can you check on Windows, I did state that. I will however check the main site too.

@MatanBobi
Copy link
Member

MatanBobi commented Nov 4, 2020

Can you check on Windows, I did state that. I will however check the main site too.

Yea, I saw that, I just didn't have a windows computer at hand when writing, sorry :)
I can verify this happens in docusaurus (also on opera browser) site also so this issue isn't related to our implementation.
Can you please open an issue there?

@maraisr
Copy link
Author

maraisr commented Nov 4, 2020

Oh gee! More wide spread than I thought. Will open an issue there, thanks mate.

@maraisr maraisr closed this as completed Nov 4, 2020
@alexkrolick alexkrolick changed the title Strange flicker on refresh Search shortcut icons detect OS after page load, can display wrong Nov 4, 2020
@maraisr
Copy link
Author

maraisr commented Nov 5, 2020

For those coming here, this has been resolved by algolia/docsearch#983

@MatanBobi once they release that, will this repo automatically pick up those changes (renovate, dependabot), or should I raise a PR to update this?

@MatanBobi
Copy link
Member

Thanks for the update and the work @maraisr!
Once they will push the new version we'll probably need to upgrade the packages with a PR.. Feel free to do that :)
Just keep an eye, docusaurus upgrades can contain breaking changes since they are still on alpha.
Thanks again!

@maraisr
Copy link
Author

maraisr commented Nov 6, 2020

nw will do! Hopefully it is painless! 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants