Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for unselect options? #180

Closed
malcolm-kee opened this issue Oct 13, 2019 · 5 comments · Fixed by #252
Closed

Support for unselect options? #180

malcolm-kee opened this issue Oct 13, 2019 · 5 comments · Fixed by #252
Labels
released

Comments

@malcolm-kee
Copy link
Collaborator

selectOptions currently force selected to true as per coded at here.

Does it make sense to support toggleOptions so we can test for unselect as well?

Let me know if you need a hand.
@nickmccurdy nickmccurdy mentioned this issue Nov 10, 2019
Closed
@Gpx
Copy link
Member

Gpx commented Feb 17, 2020

This sounds like a reasonable use case. Do you want to take a stab at it?

@malcolm-kee
Copy link
Collaborator Author

@Gpx Sure. Will work on it.

@malcolm-kee
Copy link
Collaborator Author

@Gpx I have some doubt on the desired behavior.

As a user, single-option select is not something that we can "unselect". Should toggleOptions used only for multiple select?

@Gpx
Copy link
Member

Gpx commented Apr 23, 2020

I would say yes

@malcolm-kee malcolm-kee mentioned this issue Apr 27, 2020
Merged
@kentcdodds
Copy link
Member

🎉 This issue has been resolved in version 11.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/toggleSelectOptions malcolm-kee/user-event
4 participants
@Gpx @nickmccurdy @kentcdodds @malcolm-kee