feat(keyboard): add [Tab] support
#767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d7ead36:
|
Codecov Report
@@ Coverage Diff @@
## alpha #767 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 65 +1
Lines 1325 1320 -5
Branches 512 508 -4
=========================================
- Hits 1325 1320 -5
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.0.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add support for tabbing per
keyboard.Why:
Missing default behavior.
How:
Took the implementation how to determine the tab destination from
userEvent.tab.The new keyboard behaviorPlugin also selects the whole value if the tab destination is an
inputortextarealike the browser does.Checklist:
Additional information
I'm not sure the
focusTrapoption is needed (any more).It was introduced to allow using
userEvent.tabwithfocus-trap-reactinjsdom. See #193But at first glance there is nothing in the implementation of
focus-trapthat should not work out of the box.We might be able to remove this option. Then
userEvent.tabcould be reduced to be a convenience wrapper foruserEvent.keyboard('[Tab]').