Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about (engine property) in the package.json file #129

Closed
rzkhosroshahi opened this issue Mar 28, 2020 · 3 comments
Closed

Question about (engine property) in the package.json file #129

rzkhosroshahi opened this issue Mar 28, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@rzkhosroshahi
Copy link

Hello
I have a question
Why did you add engine property in the package.json file? I have an issue with this because it makes an error in my ci/cd. that issue is my node engine version is not compatible whit engine that you added in package.json file and pipeline break up.
@rzkhosroshahi rzkhosroshahi added the bug Something isn't working label Mar 28, 2020
@afontcu
Copy link
Member

afontcu commented Mar 29, 2020

Hi!

What node version is your CI/CD pipeline running on?

@rzkhosroshahi
Copy link
Author

Hey. its 8 version

@afontcu
Copy link
Member

afontcu commented Mar 30, 2020

Then that's the reason 😄 In v5.0 we dropped support for Node 8, since it is out of LTS and we updated DOM Testing Library.

I guess you'd need to update your CI to support LTS node versions!

I'm closing this, but thanks for filling this in!
Have a great week 😃

@afontcu afontcu closed this as completed Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afontcu @rzkhosroshahi