Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lazy loading the validation modules #203 #206

Merged
merged 1 commit into from
Nov 11, 2022
Merged

fix: lazy loading the validation modules #203 #206

merged 1 commit into from
Nov 11, 2022

Conversation

richardruiter
Copy link
Collaborator

@richardruiter richardruiter commented Nov 10, 2022 •
edited

Description

The problem was that the instance of the validation wasn't configured correctly when it was turned off in the config.
Now it's lazy loaded and initialised when needed.

Fixes #203

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • This does not break any existing functionalities
  • Any dependent changes have been merged and published in downstream modules

@shubhendumadhukar shubhendumadhukar merged commit 51efd73 into testinggospels:develop Nov 11, 2022
shubhendumadhukar added a commit that referenced this pull request Nov 14, 2022
@shubhendumadhukar
Merge dev to main (#208)
c57810f 
* fix: validating parameterized paths on the openapi is now supported
* fix: lazy loading the validation modules #203 (#206)
* feat: state helper (#207)
@richardruiter richardruiter deleted the typeerror-when-validation-is-disabled branch November 16, 2022 05:28
shubhendumadhukar added a commit that referenced this pull request Nov 22, 2022
@shubhendumadhukar
feat: grpc enhancements, validation bug fixes (#211)
30ec77f 
* fix: lazy loading the validation modules #203 (#206)
* feat: state helper (#207)
* feat: cookie support for the capture helper (#209)
* implement basic error response and metadata. #188
* docs: grpc documentation
* fix: race condition with lazy loading of the validation adapters (#210)
richardruiter pushed a commit to richardruiter/camouflage that referenced this pull request Nov 28, 2022
@shubhendumadhukar @richardruiter
Merge dev to main (testinggospels#208)
03fb279 
* fix: validating parameterized paths on the openapi is now supported
* fix: lazy loading the validation modules testinggospels#203 (testinggospels#206)
* feat: state helper (testinggospels#207)
richardruiter pushed a commit to richardruiter/camouflage that referenced this pull request Nov 28, 2022
@shubhendumadhukar @richardruiter
feat: grpc enhancements, validation bug fixes (testinggospels#211)
b0dd165 
* fix: lazy loading the validation modules testinggospels#203 (testinggospels#206)
* feat: state helper (testinggospels#207)
* feat: cookie support for the capture helper (testinggospels#209)
* implement basic error response and metadata. testinggospels#188
* docs: grpc documentation
* fix: race condition with lazy loading of the validation adapters (testinggospels#210)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError in v0.10.1 when validation is disabled
2 participants
@richardruiter @shubhendumadhukar