Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

CI Build is broken. #102

Closed
tzah4748 opened this issue Dec 28, 2020 · 2 comments
Closed

CI Build is broken. #102

tzah4748 opened this issue Dec 28, 2020 · 2 comments

Comments

@tzah4748
Copy link
Contributor

@basdijkstra - Please take a look at this PR --> https://github.com/testproject-io/python-sdk/runs/1585216515?check_suite_focus=true

The problem comes from here:
https://github.com/testproject-io/python-sdk/blob/c17894162e28ca584d3912aa5f9d460ec53120ed/setup.py#L26

It fails to build because 'Appium-Python-Client' updated to v1.0.2 which requires a newer version of Selenium.

You personally made the change at --> b522217
Is there a particular reason ? can we revert it?

@basdijkstra
Copy link
Contributor

basdijkstra commented Dec 28, 2020

Appium-Python-Client 1.0.2 is OK (I've tested that myself, too), but I see in the install logs that it installed 2.0.0a0, an alpha version of a brand new Appium-Python-Client, and that's requiring Selenium 4, which is also still in alpha status.

I did not even know that setuptools installed pre-release versions unless explicitly requested, but it seems like it does: pypa/setuptools#855

The easiest way to fix this is by changing https://github.com/testproject-io/python-sdk/blob/c17894162e28ca584d3912aa5f9d460ec53120ed/setup.py#L26 to

"Appium-Python-Client>=1.0.1,<=1.0.2" (since those are the versions we have explicitly tested)

or

"Appium-Python-Client==1.0.1,==1.0.2" (which is the same as above but a little more explicit)

@tzah4748
Copy link
Contributor Author

#104

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants