Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netlify generation of envoy-versions.json can be flakey due to PR attempts #40

Open
trajendran-chwy opened this issue May 17, 2022 · 4 comments
Assignees

Comments

@trajendran-chwy
Copy link

trajendran-chwy commented May 17, 2022

Netlify's execution of the script that generates json makes a curl request to GitHub. This can overrun GH limits if for example, a PR is updated then merged inside a window. We can either stop generating preview URLs or authenticate the job inside netlify somehow.

Original:

https://archive.tetratelabs.io/envoy/envoy-versions.json returns null for all the attributes in the response.

is the service down?

This is on May 17th, 2022.

@codefromthecrypt
Copy link
Contributor

thanks for reporting! This was hitting a GitHub rate limit on building the site, I rebuilt it, but this issue should stay open until the netlify trigger is authenticated somehow

@codefromthecrypt codefromthecrypt changed the title https://archive.tetratelabs.io/envoy/envoy-versions.json returns null for all attributes netlify generation of envoy-versions.json can be flakey due to PR attempts May 17, 2022
@codefromthecrypt
Copy link
Contributor

I reworded the description after noticing the site failed to generate likely due to being built twice before in the same 10m. Might be wrong, but in any case there are some ways out of this.

Screen Shot 2022-05-17 at 3 56 15 PM

@trajendran-chwy
Copy link
Author

Thank you, tried my build and it passed. could you please recommend a best way to ensure this doesn't occur again?

@codefromthecrypt
Copy link
Contributor

Thank you, tried my build and it passed. could you please recommend a best way to ensure this doesn't occur again?

wait for this issue to close. if it is closed, it should never happen again, at least this specific problem (rate limiting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants