Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider testing arm64 on release #44

Open
codefromthecrypt opened this issue Aug 17, 2022 · 1 comment
Open

consider testing arm64 on release #44

codefromthecrypt opened this issue Aug 17, 2022 · 1 comment

Comments

@codefromthecrypt
Copy link
Contributor

codefromthecrypt commented Aug 17, 2022

Currently, our release tests don't try to test arm64.

# Note: We don't test arm64 on release as it is unlikely to fail and too much effort.
https://github.com/tetratelabs/archive-envoy/blob/master/.github/workflows/release.yaml#L63

The reason we felt it unlikely to fail was because we are using the docker images from envoy. However, it seems they aren't tested and recently added the wrong architecture to the image #43

Changing the release job to use qemu to test linux with arm64/aarch64 will at least make troubleshooting this quicker until assurances are made that the envoy docker images are all tested.

https://github.com/tetratelabs/wazero/blob/main/.github/workflows/spectest.yaml#L85 is an example of a job that uses qemu include rate limit avoidance to test non-amd64 with GitHub actions

@codefromthecrypt
Copy link
Contributor Author

codefromthecrypt commented Aug 17, 2022

note darwin binaries aren't from envoy docker, rather homebrew, as envoy doesn't publish a darwin docker image.

Moreover, currently envoy isn't kicking off homebrew formula update as a part of their processes, and the formula update routinely fails as there's no CI on HEAD envoyproxy/envoy#17500 We can still add a dimension to test darwin on arm64/aarch64 but we should comment that failures there are not docker related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant