New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize by trusting host implementations #38

Closed

mathetake opened this issue Sep 9, 2020 · 1 comment

Labels

Member

mathetake commented Sep 9, 2020 •

edited

Loading

some of the if statements can be removed by trusting host implementations:

proxy-wasm-go-sdk/proxywasm/vmstate.go

Lines 59 to 65 in 0638371

    
           if _, ok := s.rootContexts[rootContextID]; !ok { 
        
           	panic("invalid root context id") 
        
           } 
        
           if _, ok := s.streamContexts[contextID]; ok { 
        
           	panic("context id duplicated") 
        
           }

we should discuss how to deal with this

mathetake added the enhancement label

Member Author

mathetake commented Jun 15, 2021

Closing until the necessity comes up.

mathetake closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment