Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten type hierarchy removing single-implementation types #83

Closed
codefromthecrypt opened this issue Dec 22, 2021 · 2 comments
Closed

Comments

@codefromthecrypt
Copy link
Contributor

#79 removed the naivevm interpreter implementation leaving what we called wazeroir. We had to name the other implementation because there were multiple possibilities. In reality the maintenance of multiple stores implies another will never live. Let's try to reduce the amount of types and packages knowing there is only wazeroir. Part of this could be "denaming" wazeroir as it becomes the default and only impl. Any other opportunities to flatten package and type hierarchies, and generally concepts or terms should be taken as well!

@codefromthecrypt
Copy link
Contributor Author

one thing I noticed starting this is that compiler/operations.go has a lot of conceptual overlap with instructions.go most of the symbols have an exact or near match with opcodes, for example. This is probably an area we can be more direct.

@codefromthecrypt
Copy link
Contributor Author

everything is internal now so we can do any of this without impact. in fact, we've already done a lot of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant