Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipdatabase.com has shutdown #9

Closed
rodmatos opened this issue Jun 29, 2023 · 3 comments
Closed

ipdatabase.com has shutdown #9

rodmatos opened this issue Jun 29, 2023 · 3 comments

Comments

@rodmatos
Copy link

rodmatos commented Jun 29, 2023 •
edited
Loading

Apparently, ipdatabase.com has shutdown and the domain is up for sale.
This leads to the library failing due to the response sent by the webserver. https://github.com/tevslin/cloudflarepycli/blob/29ea4530ac8bf227c4090237ea2f91b8b4730d45/src/cloudflarepycli/cloudflareclass.py#L81-L88

$ curl -L https://ipdatabase.com/ip/ip_address
<html>
  <head>
    <meta http-equiv='refresh' content='0; url=https://ipdatabase.com/' />
  </head>
</html>

I wonder if it would be possible to remove the dependencies from external services, since Cloudflare should provide all the relevant information.
@ccmpbll ccmpbll mentioned this issue Jun 29, 2023
Closed
@ccmpbll
Copy link

ccmpbll commented Jun 29, 2023 •
edited
Loading

@rodmatos I used this in one of my own projects and noticed this a few days ago. I have created a pull request that removes the dependency on ipdatabase.com that should resolve the problem.

@tevslin could you please review this PR and let us know if you can approve?

@tevslin
Copy link
Collaborator

tevslin commented Jun 29, 2023 via email

@tevslin
Copy link
Collaborator

tevslin commented Jul 1, 2023

closed with version 1.8. removed dependency and added the ability to get the data from cloudflare. Thank you

@tevslin tevslin closed this as completed Jul 1, 2023
@martinbrose martinbrose mentioned this issue Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rodmatos @ccmpbll @tevslin