Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick a name? #44

Closed
browniefed opened this issue May 30, 2016 · 8 comments · Fixed by #49
Closed

Pick a name? #44

browniefed opened this issue May 30, 2016 · 8 comments · Fixed by #49
Assignees

Comments

@browniefed
Copy link
Member

I know it's nice having an umbrella but it is a bit weird doing @msafi/ for the npm install. I am unsure how npm handles redirects but you could deprecate it in favor of name packages?

I grabbed placeholders just in case.
https://www.npmjs.com/package/vanilla-text-mask
https://www.npmjs.com/package/angular-text-mask
https://www.npmjs.com/package/react-text-mask

Not sure the naming scheme you wanted. {library}-text-mask or text-mask-{library}

@msafi
Copy link
Member

msafi commented May 30, 2016

Interesting. I don't know why I didn't think of that 😄

I like the names you suggested. We can go with {library}-text-mask. And we can start looking into how to move them over.

@browniefed
Copy link
Member Author

I can transfer ownership, then I think you can run npm deprecate on the existing name, then change it to the new name and trigger a publish? Should be good to go after that, whoever is using it just need to change over to the new name and fix their code.

@browniefed
Copy link
Member Author

Also should help with library adoption! Having to type more makes it harder to install ;)

@browniefed
Copy link
Member Author

Added you to the packages

@msafi
Copy link
Member

msafi commented May 30, 2016

Cool, thanks! I also registered a bunch of {name}-text-mask packages for the future.

@browniefed
Copy link
Member Author

Awesome, I wasn't sure how to transfer ownership rather than have you as a collaborator. I think maybe if you remove me, then add me back it should transfer it?

@msafi
Copy link
Member

msafi commented May 30, 2016

I don't think it matters https://docs.npmjs.com/cli/owner

Note that there is only one level of access. Either you can modify a package, or you can't. Future versions may contain more fine-grained access levels, but that is not implemented at this time.

I think we both have the same level of access

@msafi
Copy link
Member

msafi commented May 30, 2016

I'll get to this task sometime this week or next.

@msafi msafi self-assigned this May 30, 2016
@msafi msafi mentioned this issue Jun 4, 2016
@msafi msafi closed this as completed in #49 Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants