Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed Use of localhost and 127.0.0.1 in Tour of Textile #62

Closed
undercase opened this issue May 8, 2019 · 2 comments · Fixed by #65
Closed

Mixed Use of localhost and 127.0.0.1 in Tour of Textile #62

undercase opened this issue May 8, 2019 · 2 comments · Fixed by #65

Comments

@undercase
Copy link
Contributor

In the Tour of Textile, some example commands use the address 127.0.0.1, like this:

textile comments add "Is this an outlier?" --block="QmUvWjstQzR6y7UctRJgVjcKsKzutZoiBsQw6WBXMnmg84" --api="http://127.0.0.1:41600"

While others use its alias, localhost, like this:

textile chat --thread="12D3KooWExn4ut4RV2qHXFSiWb3AfhL2whB8vJgYpnDcmVCG7UBv" --api="http://localhost:41600"

I think it would be clearer to choose one and stick to it throughout the guide, but I'm not sure what the pros and cons of each are, or if it's merely a stylistic decision. If we come to a consensus on which one to use I will update the docs to reflect it.

@sanderpick
Copy link
Member

Oh, good catch. Let's use 127.0.0.1 as the meaning of localhost can vary between OSs and we want to always imply loopback.

@undercase
Copy link
Contributor Author

Okay, I'll include this in my pull request later tonight and tag you for review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants