Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect HTML Syntax highlighting on SVG with Line break #101

Open
alexr00 opened this issue Jan 31, 2019 · 3 comments
Open

Incorrect HTML Syntax highlighting on SVG with Line break #101

alexr00 opened this issue Jan 31, 2019 · 3 comments

Comments

@alexr00
Copy link

alexr00 commented Jan 31, 2019

From @marcelcremer on January 29, 2019 13:17

  • VSCode Version:
    Version: 1.30.2 (system setup)
    Commit: 61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8
    Datum: 2019-01-07T22:53:57.820Z
    Electron: 2.0.12
    Chrome: 61.0.3163.100
    Node.js: 8.9.3
    V8: 6.1.534.41
    Betriebssystem: Windows_NT ia32 10.0.17134

  • OS Version: Windows 10

Steps to Reproduce:

Insert the following code in an HTML-File:

<div>
    <svg class="fi">
        <use xlink:href="/assets/feather/feather-sprite.svg#edit" /></svg
        >
</div>

Mind the Line break between </svg and >.

The syntax highlighting will break for everything after the SVG:
image

Found through strange SVG formatting by prettier: prettier/prettier#5541

Does this issue occur when all extensions are disabled?: Yes

Copied from original issue: microsoft/vscode#67402

@alexr00
Copy link
Author

alexr00 commented Jan 31, 2019

According to the spec this is valid HTML but the closing tag is categorized as invalid.illegal.unrecognized-tag.html

@johnsoncodehk
Copy link

I have tried to fixed this problem in VSCode, but they pointing the problem to this repo.

If someone interested in the resolve, please see microsoft/vscode#124220.

@starball5
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants