Incorrect syntax highlighting

[revolter]

This file has incorrect syntax highlighting after this line:

print("Message ID: \(userInfo["gcm.message_id"]!)")

This might be caused by the quotes inside the quotes.

[jtbandes]

Thanks for the report, I'll take a look.

@infininight This is why I wanted to use begin/end patterns 😉

[revolter]

I am quite fond of regex, could you point me to the exact line that matches it?

[jtbandes]

It's here:

swift.tmbundle/Syntaxes/Swift.tmLanguage

Lines 4361 to 4376 in 4baaa8a

	<string>(?x)
	(\\\() # Opening
	(
	(?&lt;parens&gt;
	(
	[^()"] # Anything except parens
	| \( # Matched pairs of parens
	\g&lt;parens&gt; # …that can be nested
	\)
	| " # Strings
	([^\\]|\\.)* # Contents allowing for escapes
	"
	)*
	)
	)
	((\))) # Closing

or in nicer form:

{	name = 'meta.embedded.line.swift';
	match = '(?x)
		(\\\()							# Opening
		(
			(?<parens>
				(
					[^()"]				# Anything except parens
				  | \(					# Matched pairs of parens
					\g<parens>			#  …that can be nested
					\)
				  | "					# Strings
					([^\\]|\\.)*		# Contents allowing for escapes
					"
				)*
			)
		)
		((\)))							# Closing
	';
	captures = {
		1 = { name = 'punctuation.section.embedded.begin.swift'; };
		2 = {
			name = 'source.swift';
			patterns = ( { include = '#root'; } );
		};
		5 = { name = 'punctuation.section.embedded.end.swift'; };
		6 = { name = 'source.swift'; };
	};
},

But personally, I don't think we should try to fix this regex match. I think we should replace it with begin/end patterns, as you can see in this older version of the grammar:

swift.tmbundle/Syntaxes/Swift.tmLanguage

Lines 1436 to 1481 in 662fd22

	<dict>
	<key>begin</key>
	<string>\\\(</string>
	<key>beginCaptures</key>
	<dict>
	<key>0</key>
	<dict>
	<key>name</key>
	<string>punctuation.section.embedded.begin.swift</string>
	</dict>
	</dict>
	<key>contentName</key>
	<string>source.swift</string>
	<key>end</key>
	<string>\)</string>
	<key>endCaptures</key>
	<dict>
	<key>0</key>
	<dict>
	<key>name</key>
	<string>punctuation.section.embedded.end.swift</string>
	</dict>
	<key>1</key>
	<dict>
	<key>name</key>
	<string>source.swift</string>
	</dict>
	</dict>
	<key>name</key>
	<string>meta.embedded.line.swift</string>
	<key>patterns</key>
	<array>
	<dict>
	<key>include</key>
	<string>$self</string>
	</dict>
	<dict>
	<key>begin</key>
	<string>\(</string>
	<key>comment</key>
	<string>Nested parens</string>
	<key>end</key>
	<string>\)</string>
	</dict>
	</array>
	</dict>

{	name = 'meta.embedded.line.swift';
	begin = '\\\(';
	end = '\)';
	beginCaptures = { 0 = { name = 'punctuation.section.embedded.begin.swift'; }; };
	endCaptures = {
		0 = { name = 'punctuation.section.embedded.end.swift'; };
		1 = { name = 'source.swift'; };
	};
	contentName = 'source.swift';
	patterns = (
		{	include = '$self'; },
		{	comment = 'Nested parens';
			begin = '\(';
			end = '\)';
		},
	);
},

[jtbandes]

See also: https://manual.macromates.com/en/language_grammars

[revolter]

Thanks for the info, but sadly, that's too new/much for me and I can't help.

[revolter]

@jtbandes Any idea when will GitHub pull the latest version of this?

[jtbandes]

You can watch https://github.com/github/linguist to see when they update the grammars. It may be a bit of an unusual time for them since I believe the person who usually pulled the updates is no longer working at GitHub.

[revolter]

Seems like the releases were happening quite often. I'll just wait for the next one, thanks!

[revolter]

@jtbandes, Well, there were quite a bit of releases since then, and the latest one even says it updated grammars, but the syntax for that file is still problematic.

[jtbandes]

Yes, I've tried to contact them by commenting on those commits but haven't received any response so far. I don't believe their latest changes have actually taken effect (you can see hex literals are still broken); maybe due to caching or maybe they just haven't actually deployed the changes yet.

[jtbandes]

The changes are finally out :)

[revolter]

Awesome! Thanks for letting me know. "We can now close this issue" 😆

[idrougge]

Finally!