Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up coverage reporting via CI / linting? #11

Closed
blueyed opened this issue Feb 24, 2020 · 1 comment
Closed

Setting up coverage reporting via CI / linting? #11

blueyed opened this issue Feb 24, 2020 · 1 comment

Comments

@blueyed
Copy link

blueyed commented Feb 24, 2020

  1. Are you interested on having coverage reports via CI?

I suggest using codecov for that (with a config that disables its comments, so that only PR/commit statuses are reported).

I also suggest having a tox configuration for this then, so that tox -e py38-coverage could be used on CI, but also locally in the same way.

  1. Are you interested in having some linting via CI / tox also?
    For that using flake8 might be good enough, but would require some fixes / running black/autopep8 once.

I'd be happy to contribute whatever you prefer.

@willmcgugan
Copy link
Collaborator

Yeah, I plan on setting up coverage reporting soon. Once I have more coverage to report, its currently at 52%

At the moment I'm relying on Mypy, but I'll think about some additional linting.

Thanks for the offer of help, but I can set that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants