Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fatal error in rich-4.1.0 library. In version 3.0.3, the error is not critical. #184

Closed
snooppr opened this issue Jul 27, 2020 · 3 comments

Comments

@snooppr
Copy link

snooppr commented Jul 27, 2020

  1. rich-4.1.0 library
    https://github.com/snooppr/snoop/blob/master/snoop.py#L394
In my code I use rich library (manual update), new version crashes.
    for social_network, net_info in progress1.track(site_data.items(), description=""):
  File "/home/snoop/.local/lib/python3.7/site-packages/rich/progress.py", line 710, in track
    progress.refresh()
NameError: name 'progress' is not defined
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  1. rich-3.0.3 library #I rolled back to this version of the library, but it also has a bug:
    Loss of the task completion percentage and loss of bar status (indication line), as well as incorrectly colored lines.

I rolled back to the stable version of the rich == 1.2.3 library which has no problems.
snooppr/snoop#33

@willmcgugan willmcgugan mentioned this issue Jul 27, 2020
9 tasks
@willmcgugan
Copy link
Collaborator

Please try v4.2.0

@snooppr
Copy link
Author

snooppr commented Jul 27, 2020

I checked rich version 4.2.0 (GNU / Linux) fixed and it works.
How conceived or not is now the question
This is how rich 4.2.0 works
1
The mistake here is that links are colored green, but should be system-based (set by default in the terminal.)
Regarding the update line and the percentage of completion (maybe it's even better, I can't decide yet)

And this is how rich v1.2.3 works
2
Here links are colored with the system color (correct)


v4.2.0 Bug: Lost 'calculating approximate code execution time'.
progress = Progress(TimeRemainingColumn() #bad

v1.2.3 'estimated estimated running time'

@willmcgugan
Copy link
Collaborator

See docs on highlighting.

I'm afraid I can't make much sense of your other problem. Please raise another issue with example code to help me understand what you are looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants