Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.9 build failing with Poetry. #35

Closed
ethixkr opened this issue Jul 27, 2021 · 4 comments
Closed

0.1.9 build failing with Poetry. #35

ethixkr opened this issue Jul 27, 2021 · 4 comments

Comments

@ethixkr
Copy link

ethixkr commented Jul 27, 2021

Going to admit this is my first time using Poetry so I'm not too familiar with it yet, but it appears to not like the Rich package source that's provided. No idea why. Going to try a manual install, if that fails, I'll try the regular Rich repo and hope nothings broken :)

$ poetry install
Installing dependencies from lock file

Package operations: 1 install, 0 updates, 0 removals

  • Installing rich (10.6.0 8ae1d4a): Failed

  CalledProcessError

  Command '['git', 'clone', '--recurse-submodules', 'git@github.com:willmcgugan/rich', '/home/hyoon/.local/share/virtualenvs/textual-4a5vNUb8/src/rich']' returned non-zero exit status 128.

  at ~/.local/lib/python3.6/site-packages/poetry/utils/_compat.py:218 in run
      214│                 raise
      215│             retcode = process.poll()
      216│             if check and retcode:
      217│                 raise CalledProcessError(
    → 218│                     retcode, process.args, output=stdout, stderr=stderr
      219│                 )
      220│         finally:
      221│             # None because our context manager __exit__ does not use them.
      222│             process.__exit__(None, None, None)
=== test session starts ===
platform linux (ubuntu 18) -- Python 3.7.11, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 -- /home/hyoon/.local/share/virtualenvs/textual-4a5vNUb8/bin/python
cachedir: .pytest_cache
...
Coverage.py warning: Module textual was never imported. (module-not-imported)

(because of the build fail)

Will report back,.

@ethixkr
Copy link
Author

ethixkr commented Jul 27, 2021

Whoops. Meant to post this in the discussions section 😅 Apologies

@lllama
Copy link
Contributor

lllama commented Jul 27, 2021

Might be worth posting your pyproject.toml. My project is installing that version of rich. I'm using main from the repo for textual:

textual = { git = "https://github.com/willmcgugan/textual.git", branch = "main" }

I am installing on python 3.8. Not sure if that makes a difference compared to your 3.7.

@ethixkr
Copy link
Author

ethixkr commented Jul 27, 2021

Fixed by making a wheel file of the branch link-id and manually installing through pip.

Anywho, this was the toml config:

[tool.poetry.dependencies]
python = "^3.7"
#rich = "^10.6.0"
rich = {git = "git@github.com:willmcgugan/rich", rev = "link-id"}
typing-extensions = { version = "^3.10.0", python = "<3.8" }

26 passed in 0.92s hurrah! Time to play :)

@ethixkr
Copy link
Author

ethixkr commented Jul 27, 2021

This is amazing. It's so beautiful 😭 I love you Will.

@ethixkr ethixkr closed this as completed Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants