Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type for DataTable.get_cell_coordinate column_key? #3972

Closed
geoff-va opened this issue Jan 7, 2024 · 2 comments · Fixed by #3991
Closed

Incorrect type for DataTable.get_cell_coordinate column_key? #3972

geoff-va opened this issue Jan 7, 2024 · 2 comments · Fixed by #3991
Assignees
@rodrigogiraoserrao
Labels
bug Something isn't working

Comments

@geoff-va
Copy link

geoff-va commented Jan 7, 2024

Was noticing mypy was giving me flack for using a ColumnKey in DataTable.get_cell_coordinate as the column_key. Looks to be typed as Column, but given the name and usage I'm guessing it should be a ColumnKey?

Thanks!
@Textualize Textualize deleted a comment from github-actions bot Jan 9, 2024
@rodrigogiraoserrao
Copy link
Contributor

Thanks for spotting this!

@rodrigogiraoserrao rodrigogiraoserrao mentioned this issue Jan 9, 2024
Merged
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Jan 9, 2024
@rodrigogiraoserrao rodrigogiraoserrao added the bug Something isn't working label Jan 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typing fix in DataTable.get_cell_coordinate Textualize/textual
2 participants
@rodrigogiraoserrao @geoff-va