Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env var to modify animation #3992

Closed
willmcgugan opened this issue Jan 9, 2024 · 3 comments · Fixed by #4062
Closed

Env var to modify animation #3992

willmcgugan opened this issue Jan 9, 2024 · 3 comments · Fixed by #4062
Assignees
Labels
enhancement New feature or request Task

Comments

@willmcgugan
Copy link
Collaborator

willmcgugan commented Jan 9, 2024

Add an environment variable to set animation behaviour.

TEXTUAL_ANIMATION should be one of the following values:

NONE for no animation at all.
BASIC for scrolling animation and other animation that doesn't delay content appearing (such as the tab underline).
FULL for all animations.

Any other values should be equivalent to FULL

This should also be replicated in App with a property, so it could be set programatically.

@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Jan 18, 2024
@rodrigogiraoserrao rodrigogiraoserrao added enhancement New feature or request Task labels Jan 18, 2024
@rodrigogiraoserrao
Copy link
Contributor

This looks like it'll take a couple of days because I need to figure out a way for the animations code to determine whether or not an animation is “basic”.
(If it were just NONE vs FULL, it'd be simpler.)

@rodrigogiraoserrao
Copy link
Contributor

Looks like we don't want TEXTUAL_ANIMATIONS to interfere with the parameter delay that is set on some animations.
A delayed animation with TEXTUAL_ANIMATIONS set to NONE will be delayed for the correct amount of time and then it happens instantaneously.

rodrigogiraoserrao added a commit that referenced this issue Jan 25, 2024
The original issue (#3992) asked for a property on 'App' that allows controlling whether that app's animations should be played or not.
Copy link

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants